fix: replace invalid UTF-8 in metadata to JSON with U+FFFD #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DICOM files can contain invalid UTF-8 in metadata. JavaScript JSON.parse() rejects invalid UTF-8
This was referenced Oct 22, 2025
thewtex
merged commit 7eacc02
into
InsightSoftwareConsortium:main
81 of 83 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DICOM files can contain invalid UTF-8 in metadata. JavaScript JSON.parse() rejects invalid UTF-8
We will need to rebuild the WASM building docker images.
I looked into updating to c++23 and using Glaze's
escape_control_characters = truePaulHax#3But that did not sanitize the binary garbage in the date tags in this example dicom corrupt_dates.zip
Closes #1454