Skip to content

Add constexpr to variables initialized by T::Filled(x) #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add constexpr to variables initialized by T::Filled(x) #4942

merged 3 commits into from
Nov 11, 2024

Conversation

@N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Nov 9, 2024

@N-Dekker
STYLE: Add constexpr to variables initialized by T::Filled(int-literal)
c0b08ad 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)(auto \w+[ ]+= .+::Filled\(\d+\);)
    Replace with: $1constexpr $2
    Filters: itk*.* !+\test
    Directory: D:\src\ITK\Modules
    [v] Match case
    (*) Regular expression

Manually excluded cases that did not compile, in

    itkLabelMapContourOverlayImageFilter.hxx
    itkBSplineControlPointImageFilter.hxx
    itkBSplineScatteredDataPointSetToImageFilter.hxx
    itkTileImageFilter.hxx
    itkFFTDiscreteGaussianImageFilter.hxx
    itkSLICImageFilter.hxx

 - Follow-up to pull request InsightSoftwareConsortium#4930
commit fd14482
"STYLE: Add constexpr to variables initialized by MakeFilled"
@N-Dekker
STYLE: Add constexpr to radius in WindowedSincInterpolateImageFunction
4e2bdc2 
`Size::Filled(VRadius)` can be evaluated at compile-time.
@N-Dekker
STYLE: Add constexpr to supportSize in BSplineDeformableTransform
4b84db0 
`SizeType::Filled(SplineOrder + 1)` can be evaluated at compile-time.
@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Numerics Issues affecting the Numerics module labels Nov 9, 2024
@N-Dekker N-Dekker marked this pull request as ready for review November 9, 2024 22:11
@hjmjohnson hjmjohnson merged commit dab1987 into InsightSoftwareConsortium:master Nov 11, 2024
15 checks passed
@N-Dekker N-Dekker deleted the Add-constexpr-to-variables-initialized-by-Filled branch November 15, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-Dekker @hjmjohnson @dzenanz