BUG: Remove check on WrapITK.pth existence in itk_python_add_test#5281
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:releasefrom Mar 19, 2025
Merged
Conversation
github-actions
bot
added
type:Bug
dzenanz
reviewed
Mar 18, 2025
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
LGTM, but Matt and/or Hans should review too.
Member
|
LGTM @SimonRit did you want this also included in ITK 5.4.3? |
Author
|
It would be great yes. Should I rebase on release? |
hjmjohnson
approved these changes
Mar 18, 2025
Member
@SimonRit yes, please. |
Author
Done! |
Member
|
@SimonRit thanks! I seem to have pushed a rebase at the exact same time BTW. |
thewtex
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check fails when using itk_python_add_test in external and remote modules as the macro is called before initializing WrapITK.pth. This check was added with 22998bd but the file is always created and configured since
12e8d93 so removing the check should not harm.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.