COMP: Fix error made by bcb6876: module vtkvtksys not available #5512
Conversation
Commit bcb6876 introduced a configure error: CMake Error at C:/Libs/VTK-8.2.0/CMake/vtkModuleAPI.cmake:140 (message): Requested modules not available: vtkvtksys Call Stack (most recent call first): Modules/Bridge/VtkGlue/itk-module-init.cmake:93 (vtk_module_config) CMake/ITKModuleEnablement.cmake:436 (include) CMakeLists.txt:754 (include) -- Configuring incomplete, errors occurred!
github-actions
bot
added
type:Compiler
|
Hi Dzenan, sorry for the inconvenience. This is indeed the fix I would have suggested too! :) |
|
itkFFTConvolutionImageFilterStreamingValidTest (Failed) in macOS-x86_64-rosetta. Here is the tail of the log: Does anyone know why doesn't this build show up on the dashboard? |
|
@dzenanz I am working on an FFTW fix that might be related to this. diff --git a/CMake/itkExternal_FFTW.cmake b/CMake/itkExternal_FFTW.cmake
index f268919a4c4..6369eaeeb98 100644
--- a/CMake/itkExternal_FFTW.cmake
+++ b/CMake/itkExternal_FFTW.cmake
@@ -96,7 +96,9 @@ if(NOT ITK_USE_SYSTEM_FFTW)
-DCMAKE_C_FLAGS:STRING=${CMAKE_C_FLAGS}
-DCMAKE_OSX_SYSROOT:PATH=${CMAKE_OSX_SYSROOT}
-DCMAKE_OSX_DEPLOYMENT_TARGET:PATH=${CMAKE_OSX_DEPLOYMENT_TARGET}
+ -DCMAKE_OSX_ARCHITECTURES:STRING=${CMAKE_OSX_ARCHITECTURES}
-DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=${CMAKE_POSITION_INDEPENDENT_CODE}
+ -DCMAKE_POLICY_VERSION_MINIMUM:STRING=${ITK_OLDEST_VALIDATED_POLICIES_VERSION}
)
# set(
# FFTW3f_DIR ${FFTW_STAGED_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/cmake/fftw3f
@@ -152,7 +154,9 @@ if(NOT ITK_USE_SYSTEM_FFTW)
-DCMAKE_C_FLAGS:STRING=${CMAKE_C_FLAGS}
-DCMAKE_OSX_SYSROOT:PATH=${CMAKE_OSX_SYSROOT}
-DCMAKE_OSX_DEPLOYMENT_TARGET:PATH=${CMAKE_OSX_DEPLOYMENT_TARGET}
+ -DCMAKE_OSX_ARCHITECTURES:STRING=${CMAKE_OSX_ARCHITECTURES}
-DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=${CMAKE_POSITION_INDEPENDENT_CODE}
+ -DCMAKE_POLICY_VERSION_MINIMUM:STRING=${ITK_OLDEST_VALIDATED_POLICIES_VERSION}
DEPENDS
${PROJ_FFTWD_DEPENDS} # Avoid potential collisions on install
) |
|
Merging as is, the new dashboard failure for new platform "macOS-x86_64-rosetta" is unrelated to this PR |
hjmjohnson
merged commit 8c56947
into
InsightSoftwareConsortium:main
|
Bisecting these build errors led me to this PR. The error messages themselves are rather non-descriptive. Invoking |
|
Interestingly, these build failures started on September 9th, not immediately. |
|
@bradking Is there some way to get more verbose output from CastXML? |
|
That log shows |
|
Is there an easy way to get the exact parameters (and environment?) it was invoked with? It is over pretty quickly. Also, building this on Windows is quite an undertaking, so debugging is not easy. |
|
There is no such option to |
|
It reminds me of an issue we got on Activiz. We also use castxml to wrap VTK in C#, and with the latest MSVC toolset (19.44, which the CI seems to be using), we also had crashes in castxml. I didn't investigate much and simply built an upstream castxml with this MSVC version and it works fine now. It may be worth a try. |
|
@thewtex I do not have the build setup for |
|
Version 17.14.14 was released September 9th, which exactly correlates with the start of build failures. |
|
Another build of Windows binaries is here: CastXML/CastXMLSuperbuild#76 |
The GitHub Actions windows-2022 runner image for MSVC compatibility re: Issue InsightSoftwareConsortium#5512.
|
Running A similar trace now also appears in Visual Studio output window: |
|
I also submitted a bug report to Visual Studio: https://developercommunity.visualstudio.com/t/Since-version-171414-ITK-with-Python/10968323 |
|
@dzenanz did your build work prior to the CastXML version bump? |
|
What broke the build was VS update on September 9th, or maybe something else that happened on the same day (PATH environment variable change, Git update, etc). |
|
The build errors seem unrelated to CastXML version. |
|
After more testing, I conclude that PR #5509 broke things. I guess that the new way to build Windows binaries is faulty. Should we revert it for now? Or do we expect a fix soon? |
|
The old binaries do not depend on |
I will look into it. |
5 participants
Commit bcb6876 introduced a configure error:
PR Checklist