Remove zero-initialized variables declared as itk::Index or IndexType from region initialization in test
#5635
+47
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `constexpr itk::Index` variables initialized by zero's, that were only there as the index argument of a region initialization. Follow-up to pull request InsightSoftwareConsortium#5627 commit f9885d2 "STYLE: Remove `T::IndexType index{}` from region initialization in tests"
github-actions
bot
added
type:Testing
Removed `IndexType` variables initialized by zero's (`{ 0, ..., 0 }`), that were
only there as the index argument of a region initialization.
Using Notepad++, Replace in Files (Search Mode: Regular expression), doing:
Find what: `^( [ ]+)constexpr IndexType[ ]+(\w+){[0, ]*};[\r\n]+\1(.*[rR]egion.* \w+)\(\2, (.*)\);$`
Find what: `^( [ ]+)constexpr IndexType[ ]+(\w+){[0, ]*};[\r\n]+\1(.*[rR]egion.* \w+){ \2, (.*) }];$`
Find what: `^( [ ]+)constexpr IndexType[ ]+(\w+){[0, ]*};[\r\n]+\1(.*[rR]egion.* \w+) = { \2, (.*) };$`
Replace with: $1$3{ $4 };
Manually fixed itkCenteredVersorTransformInitializerTest.cxx compile errors
after removing `index`. Removed `IndexType` that have become unused with this
commit.
Follow-up to pull request InsightSoftwareConsortium#5627
commit f9885d2
"STYLE: Remove `T::IndexType index{}` from region initialization in tests"
N-Dekker
force-pushed
the
Remove-itk-Index-from-region-initialization-in-tests
branch
from
2b2faec to
495d45b
Compare
dzenanz
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to
T::IndexType index{}from region initialization in tests #5627T::IndexType index{0}from region initialization in test #5628