COMP: Use modern macro for name of class #86
Conversation
|
@dzenanz Part of slicer updates |
|
@dzenanz Updates for supporting newer ITK. |
|
PR #85 maybe needs to be done first. |
hjmjohnson
force-pushed
the
fix-legacy-remove
branch
3 times, most recently
from
8f286c1 to
151c40e
Compare
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I guess we will have to leave CI greening for some later date. With these changes, does this build when Module_IOScanco is turned on?
hjmjohnson
force-pushed
the
fix-legacy-remove
branch
from
fbc4ea2 to
d8485a5
Compare
When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON The future preferred macro should be used │ - itkTypeMacro │ + itkOverrideGetNameOfClassMacro
The convention of only specifying the MAJOR version is the indicator that the latest version in that series should be used. By not specifying the MINOR and PATCH, the exact versions is not pinned, but the latest in that series is chosen. (i.e. the v5 tag is updated every time a new MINOR or PATCH tag is generated). This allows benefiting from minor patch fixes without needing to update workflows.
Set the default build package tags to v5.4.2 for capturing the ITKRemoteModuleBuildTestPackageAction shared scripts. This pulls the default configuration items needed to build against ITK version v5.4.2.
Match version for ITK v5.4.2
hjmjohnson
force-pushed
the
fix-legacy-remove
branch
from
db6047c to
11ea266
Compare
|
Warning: |
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I think that the changes here only expose pre-existing issue with that warning. Still, it is preferable to fix it to have a clean CI.
|
This should probably be merged before #87. Merge as-is or try to fix the failure? |
|
@dzenanz I agree with you. I think this should be merged as is. No new errors are represented. I do not have access rights to do the merge. |
dzenanz
merged commit 01144b9
into
InsightSoftwareConsortium:master
2 participants
When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON
The future preferred macro should be used
│ - itkTypeMacro
│ + itkOverrideGetNameOfClassMacro