COMP: Update CI workflows for remote module#40
Conversation
hjmjohnson
commented
Feb 1, 2025
- STYLE: Add itkVirtualGetNameOfClassMacro + itkOverrideGetNameOfClassMacro
- STYLE: Update to match clang-format-19 from ITK
- ENH: Update to support the clang-format-linter CI
- COMP: Update workflow package dependancy versions.
- COMP: Select latest remote build branch.
f028970 to
797dc03
Compare
|
@hjmjohnson thanks for all your efforts to get this through! I see it has been quite an odyssey. I need this module too, but a nice workaround (for me) would be to enable this module in SimpleITK wheels on pypi. @blowekamp would this be of any interest? |
@dyollb These filters are already specified in SimpleITK: But as a remote module they are turned off by default. If you compile SimpleITK yourself it can be enabled: The SimpleITK pypi binaries can be large and the the compilation and linking cumbersome. However we can evaluate the impact of these filter. Can you make a PR to simpleITK which enables this module by default? |
5791d63 to
0fd381e
Compare
|
Thanks for doing this Hans. In case it is of any help, the errors on the Are already taken care of when using the |
0fd381e to
6c43191
Compare
|
There are conflicts, can you rebase? |
…acro Added two new macro's, intended to replace the old 'itkTypeMacro' and 'itkTypeMacroNoParent'. The main aim is to be clearer about what those macro's do: add a virtual 'GetNameOfClass()' member function and override it. Unlike 'itkTypeMacro', 'itkOverrideGetNameOfClassMacro' does not have a 'superclass' parameter, as it was not used anyway. Note that originally 'itkTypeMacro' did not use its 'superclass' parameter either, looking at commit 699b66cb04d410e555656828e8892107add38ccb, Will Schroeder, June 27, 2001: https://github.com/InsightSoftwareConsortium/ITK/blob/699b66cb04d410e555656828e8892107add38ccb/Code/Common/itkMacro.h#L331-L337
6c43191 to
87389e9
Compare