BUG: Fix Valgrind defect with uninitialized array in doOneDimensionErode#49
Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 5, 2025
Conversation
Co-author: Jon Haitz Legarreta Gorroño <jon.haitz.legarreta@gmail.com>
dzenanz
approved these changes
Mar 3, 2025
Member
|
And this is different from #45 because a different variable (on a different line of code) is initialized? |
Member
Author
Yes, this other PR did not fix the valgrind defect. This one did. |
jhlegarreta
reviewed
Mar 3, 2025
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Thanks for the co-authorship Brad. I would have liked to see the commit message contain a more informative text, e.g. C&P from PR#45. But feel free to merge.
Member
Author
|
My message may be on the short size. But including a URL which will become invalid, and a full stack trace IMHO is excessive. In prior PR, I included that information in the PR only to aid in review and not the commit message to be stored permanently in the git history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-author: Jon Haitz Legarreta Gorroño jon.haitz.legarreta@gmail.com
This fix was confirmed with running valgrind.