COMP: Add extra double parameter to InterpolateImageFunction wrapping templates#236
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:mainfrom Aug 28, 2025
Merged
Conversation
Member
|
I think we also need to update the CI to use ITK 5.4.4. I will not have time to do that this week, so if you could do it that would be appreciated. |
Set the default build package tags to v5.4.4 for capturing the ITKRemoteModuleBuildTestPackageAction shared scripts. This pulls the default configuration items needed to build against ITK version v5.4.4.
Member
|
Merging as-is. If you can address notebook CI failure in a follow-up PR, that would be great. |
dzenanz
merged commit 04bd571
into
InsightSoftwareConsortium:main
62 of 65 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added extra double parameter to InterpolateImageFunction wrapping templates.
From what I can determine, both itkLinearInterpolateImageFunction and itkNearestNeighborInterpolateImageFunction are both wrapped using only double for the TCoordRep template parameter.
This appears to eliminate the displayed wrapping warnings, as described in https://discourse.itk.org/t/supressing-eliminating-python-wrapping-warnings/7616