Skip to content

Commit ff710f5

Browse files
author
Ali Abdelfattah
authored
Merge pull request #241 from Instabug/chore/bump-native-sdks-v11
[MOB-8893] Bump Native SDKs to v11
2 parents 9046a08 + 5e67baf commit ff710f5

File tree

6 files changed

+6
-15
lines changed

6 files changed

+6
-15
lines changed

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ android {
3434
}
3535
}
3636
dependencies {
37-
implementation 'com.instabug.library:instabug:10.13.0'
37+
implementation 'com.instabug.library:instabug:11.2.0'
3838
testImplementation 'junit:junit:4.12'
3939
}
4040

android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,6 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
175175
args.put("CustomTextPlaceHolderKey.conversationsListTitle", InstabugCustomTextPlaceHolder.Key.CONVERSATIONS_LIST_TITLE);
176176
args.put("CustomTextPlaceHolderKey.audioRecordingPermissionDenied", InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED);
177177
args.put("CustomTextPlaceHolderKey.conversationTextFieldHint", InstabugCustomTextPlaceHolder.Key.CONVERSATION_TEXT_FIELD_HINT);
178-
args.put("CustomTextPlaceHolderKey.bugReportHeader", InstabugCustomTextPlaceHolder.Key.BUG_REPORT_HEADER);
179-
args.put("CustomTextPlaceHolderKey.feedbackReportHeader", InstabugCustomTextPlaceHolder.Key.FEEDBACK_REPORT_HEADER);
180178
args.put("CustomTextPlaceHolderKey.voiceMessagePressAndHoldToRecord", InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD);
181179
args.put("CustomTextPlaceHolderKey.voiceMessageReleaseToAttach", InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_RELEASE_TO_ATTACH);
182180
args.put("CustomTextPlaceHolderKey.reportSuccessfullySent", InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT);

android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,6 @@ private List<InstabugCustomTextPlaceHolder.Key> getCurrentlySupportedKeysBySDK()
267267
keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATIONS_LIST_TITLE);
268268
keys.add(InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED);
269269
keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATION_TEXT_FIELD_HINT);
270-
keys.add(InstabugCustomTextPlaceHolder.Key.BUG_REPORT_HEADER);
271-
keys.add(InstabugCustomTextPlaceHolder.Key.FEEDBACK_REPORT_HEADER);
272270
keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD);
273271
keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_RELEASE_TO_ATTACH);
274272
keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT);
@@ -307,8 +305,6 @@ private List<InstabugCustomTextPlaceHolder.Key> getAllCustomTextPlaceHolderKeys(
307305
keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATIONS_LIST_TITLE);
308306
keys.add(InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED);
309307
keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATION_TEXT_FIELD_HINT);
310-
keys.add(InstabugCustomTextPlaceHolder.Key.BUG_REPORT_HEADER);
311-
keys.add(InstabugCustomTextPlaceHolder.Key.FEEDBACK_REPORT_HEADER);
312308
keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD);
313309
keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_RELEASE_TO_ATTACH);
314310
keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT);

ios/Classes/InstabugFlutterPlugin.m

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -649,9 +649,10 @@ + (void)showSurveyWithToken:(NSString *)surveyToken {
649649
* @return the desired value of whether the user has responded to the survey or not.
650650
*/
651651
+ (void)hasRespondedToSurveyWithToken:(NSString *)surveyToken {
652-
bool hasResponded = [IBGSurveys hasRespondedToSurveyWithToken:surveyToken];
653-
NSNumber *boolNumber = [NSNumber numberWithBool:hasResponded];
654-
[channel invokeMethod:@"hasRespondedToSurveyCallback" arguments:boolNumber];
652+
[IBGSurveys hasRespondedToSurveyWithToken:surveyToken completionHandler:^(BOOL hasResponded){
653+
NSNumber *boolNumber = [NSNumber numberWithBool:hasResponded];
654+
[channel invokeMethod:@"hasRespondedToSurveyCallback" arguments:boolNumber];
655+
}];
655656
}
656657

657658
/**
@@ -1052,8 +1053,6 @@ + (NSDictionary *)constants {
10521053
@"CustomTextPlaceHolderKey.conversationsListTitle": kIBGChatsTitleStringName,
10531054
@"CustomTextPlaceHolderKey.audioRecordingPermissionDenied": kIBGAudioRecordingPermissionDeniedTitleStringName,
10541055
@"CustomTextPlaceHolderKey.conversationTextFieldHint": kIBGChatReplyFieldPlaceholderStringName,
1055-
@"CustomTextPlaceHolderKey.bugReportHeader": kIBGReportBugStringName,
1056-
@"CustomTextPlaceHolderKey.feedbackReportHeader": kIBGReportFeedbackStringName,
10571056
@"CustomTextPlaceHolderKey.voiceMessagePressAndHoldToRecord": kIBGRecordingMessageToHoldTextStringName,
10581057
@"CustomTextPlaceHolderKey.voiceMessageReleaseToAttach": kIBGRecordingMessageToReleaseTextStringName,
10591058
@"CustomTextPlaceHolderKey.reportSuccessfullySent": kIBGThankYouAlertMessageStringName,

ios/instabug_flutter.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ A new flutter plugin project.
1515
s.source_files = 'Classes/**/*'
1616
s.public_header_files = 'Classes/**/*.h'
1717
s.dependency 'Flutter'
18-
s.dependency 'Instabug', '10.13.0'
18+
s.dependency 'Instabug', '11.0.2'
1919

2020
s.ios.deployment_target = '10.0'
2121
s.pod_target_xcconfig = { 'OTHER_LDFLAGS' => '-framework "Flutter" -framework "Instabug"'}

lib/Instabug.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ enum CustomTextPlaceHolderKey {
6767
conversationsListTitle,
6868
audioRecordingPermissionDenied,
6969
conversationTextFieldHint,
70-
bugReportHeader,
71-
feedbackReportHeader,
7270
voiceMessagePressAndHoldToRecord,
7371
voiceMessageReleaseToAttach,
7472
reportSuccessfullySent,

0 commit comments

Comments
 (0)