Skip to content

feat: add ndk crashes API #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

feat: add ndk crashes API #607

wants to merge 7 commits into from

Conversation

MoKamall
Copy link
Collaborator

Description of the change

Added new API that sets the state of NDK crashes (enabled/disabled)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://instabug.atlassian.net/browse/MOB-19406

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@MoKamall MoKamall self-assigned this Jul 22, 2025
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 22, 2025 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 83.8% ✅

Generated by 🚫 dangerJS against 6f1ae20

@MoKamall MoKamall marked this pull request as ready for review July 28, 2025 09:50
@MoKamall MoKamall requested review from ahmedAlaaInstabug and removed request for ahmedAlaaInstabug July 28, 2025 09:50
AndrewAminInstabug
AndrewAminInstabug reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort 👏👏 can we add unit test for it in dart and java sides ?

AyaMahmoud148
AyaMahmoud148 previously approved these changes Jul 29, 2025
View reviewed changes
ahmedAlaaInstabug
ahmedAlaaInstabug requested changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏 , but it would be more beneficial to add unit tests for both the Dart and Android implementations of the setNDKEnabled method.

@MoKamall
test: add NDK enabled tests for CrashReporting API
5fcad06 
- Implemented unit tests for `setNDKEnabled` method in both Java and Dart.
- Verified that enabling and disabling NDK crash reporting calls the appropriate host methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

Assignees

@MoKamall MoKamall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoKamall @InstabugCI @ahmedAlaaInstabug @AndrewAminInstabug @AyaMahmoud148