[GCSI-515] update fastlane build actions android/ios #2
Conversation
…ld path and + specs
| def self.fetch_android_build_path(lane_context) | ||
| all_aab_paths = lane_context[Actions::SharedValues::GRADLE_ALL_AAB_OUTPUT_PATHS] | ||
| return all_aab_paths if all_aab_paths && !all_aab_paths.empty? | ||
|
|
||
| aab_path = lane_context[Actions::SharedValues::GRADLE_AAB_OUTPUT_PATH] | ||
| return aab_path if aab_path && !aab_path.empty? | ||
|
|
||
| all_apk_paths = lane_context[Actions::SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS] | ||
| return all_apk_paths if all_apk_paths && !all_apk_paths.empty? | ||
|
|
||
| apk_path = lane_context[Actions::SharedValues::GRADLE_APK_OUTPUT_PATH] | ||
| return apk_path if apk_path && !apk_path.empty? | ||
|
|
||
| return nil | ||
| end |
There was a problem hiding this comment.
| def self.fetch_android_build_path(lane_context) | |
| all_aab_paths = lane_context[Actions::SharedValues::GRADLE_ALL_AAB_OUTPUT_PATHS] | |
| return all_aab_paths if all_aab_paths && !all_aab_paths.empty? | |
| aab_path = lane_context[Actions::SharedValues::GRADLE_AAB_OUTPUT_PATH] | |
| return aab_path if aab_path && !aab_path.empty? | |
| all_apk_paths = lane_context[Actions::SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS] | |
| return all_apk_paths if all_apk_paths && !all_apk_paths.empty? | |
| apk_path = lane_context[Actions::SharedValues::GRADLE_APK_OUTPUT_PATH] | |
| return apk_path if apk_path && !apk_path.empty? | |
| return nil | |
| end | |
| def self.fetch_android_build_path(lane_context) | |
| build_keys = [ | |
| Actions::SharedValues::GRADLE_APK_OUTPUT_PATH, | |
| Actions::SharedValues::GRADLE_AAB_OUTPUT_PATH, | |
| Actions::SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS, | |
| Actions::SharedValues::GRADLE_ALL_AAB_OUTPUT_PATHS | |
| ] | |
| build_keys.each do |build_key| | |
| build_path = lane_context[build_key] | |
| return build_path if build_path.presence | |
| end | |
| end |
There was a problem hiding this comment.
I thought that APK is more popular than AAB & single-variant is used more than multi-variant?
Is this wrong? Any order is fine with me 3moman...
There was a problem hiding this comment.
Also, why not move this function to the build_android since it won't be used by any other action?
There was a problem hiding this comment.
sure will update it
There was a problem hiding this comment.
@ahmedhany98 shouldn't the priority for multi-variant so that if not multi-variant, we should check the single variant ? i thought that
but will double check let me know if u are sure
There was a problem hiding this comment.
I think checking the most commonly used paths earlier in the array is slightly better.
The order won't affect the logic 3moman since they can only have one of the constants. The single-variant value should be undefined in case of multi-variant based on their comment here
We can check for the multi-variant first to follow their structure here.
| FastlaneCore::ConfigItem.new( | ||
| key: :instabug_api_base_url, | ||
| env_name: "INSTABUG_API_BASE_URL", | ||
| description: "Instabug API base URL (defaults to https://api.instabug.com)", | ||
| optional: true, | ||
| type: String, | ||
| skip_type_validation: true # Since we don't extract this param | ||
| ) |
There was a problem hiding this comment.
I don't understand this point.
Should the STs customers pass the env_var as a param? or we will be fetching it directly if exist?
There was a problem hiding this comment.
@ahmedhany98, it will be an ENV var, which is optional normally
Let me illustrate
- env vars can not included in available options normally as they aren't params
- i included it for documentation as when the user checks the available action can found the description for it and the env name
- so i added skip_type_validation so that the user shouldn't include it as a param and can export it as env var
as example he only should
export INSTABUG_API_BASE_URL =urland no need to send it to us as fastlane read the env vars passed to it
There was a problem hiding this comment.
Tmam perfect. Thank you for explaining 🙏
| ] | ||
| build_keys.each do |build_key| | ||
| build_path = lane_context[build_key] | ||
| return build_path if build_path && !build_path.empty? |
There was a problem hiding this comment.
| return build_path if build_path && !build_path.empty? | |
| return build_path if build_path.present? |
No description provided.