[IBGBUGCHAT-10593] support certificate content type#6
Open
smohamedinstabug wants to merge 1 commit intourl-filterfrom
Open
[IBGBUGCHAT-10593] support certificate content type#6smohamedinstabug wants to merge 1 commit intourl-filterfrom
smohamedinstabug wants to merge 1 commit intourl-filterfrom
Conversation
9361442 to
ae817ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
filecommand considers the pem files as “text/plain” andmimemagiccan't detect the pem files content typeSolution:
Try to open a file with
OpenSSL::X509::Certificate. so If the file opened successfully, it will be a pem file.Notes:
TODO: anything that reviewers should know before reviewing?
QC Notes:
TODO: What parts/flows of the app are affected by this change?
Release steps:
TODO: steps needed for the release. If no special handling needed, please write 'Normal Release'
Security:
TODO: Are the changes exposed publicly or internally?
TODO: Do all new endpoints impose proper access to authorized users only?
Network:
TODO: Link to Ops PR if any. Type N/A if none.
TODO: List new internal/external services communications that were introduced in this PR. Type N/A if none.
Author checklist:
Reviewer checklist: