Skip to content

Make VALID and INVALID covariant #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyreese merged 1 commit into from
Nov 15, 2025
Merged

Make VALID and INVALID covariant #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fixit/rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ class LintRule(BatchableCSTVisitor):
__ https://peps.python.org/pep-0440/#version-specifiers
"""

VALID: ClassVar[List[Union[str, Valid]]]
VALID: ClassVar[Sequence[Union[str, Valid]]]
"Test cases that should produce no errors/reports"

INVALID: ClassVar[List[Union[str, Invalid]]]
INVALID: ClassVar[Sequence[Union[str, Invalid]]]
"Test cases that are expected to produce errors, with optional replacements"

AUTOFIX = False # set by __subclass_init__
Expand Down