Skip to content

Всегда возвращать id решения после его публикации #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DedSec256 merged 2 commits into from
Oct 21, 2025
Merged

Всегда возвращать id решения после его публикации #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78bf130
fix: always return solution id in post solution
semrosin Oct 20, 2025
8c41862
refactor: local result for each branch
semrosin Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions HwProj.APIGateway/HwProj.APIGateway.API/Controllers/SolutionsController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,27 +301,29 @@ public async Task<IActionResult> PostSolution(PostSolutionModel model, long task
var result = await _solutionsClient.PostSolution(taskId, solutionModel);
return Ok(result);
}
else
{
var fullStudentsGroup = model.GroupMateIds.ToList();
fullStudentsGroup.Add(solutionModel.StudentId);
var arrFullStudentsGroup = fullStudentsGroup.Distinct().ToArray();

var fullStudentsGroup = model.GroupMateIds.ToList();
fullStudentsGroup.Add(solutionModel.StudentId);
var arrFullStudentsGroup = fullStudentsGroup.Distinct().ToArray();

if (arrFullStudentsGroup.Intersect(course.CourseMates.Select(x => x.StudentId)).Count() !=
arrFullStudentsGroup.Length)
return BadRequest();
if (arrFullStudentsGroup.Intersect(course.CourseMates.Select(x => x.StudentId)).Count() !=
arrFullStudentsGroup.Length)
return BadRequest();

var existedGroup = course.Groups.SingleOrDefault(x =>
x.StudentsIds.Length == arrFullStudentsGroup.Length &&
x.StudentsIds.Intersect(arrFullStudentsGroup).Count() == arrFullStudentsGroup.Length);
var existedGroup = course.Groups.SingleOrDefault(x =>
x.StudentsIds.Length == arrFullStudentsGroup.Length &&
x.StudentsIds.Intersect(arrFullStudentsGroup).Count() == arrFullStudentsGroup.Length);

solutionModel.GroupId =
existedGroup?.Id ??
await _coursesServiceClient.CreateCourseGroup(new CreateGroupViewModel(arrFullStudentsGroup, course.Id),
taskId);
solutionModel.GroupId =
existedGroup?.Id ??
await _coursesServiceClient.CreateCourseGroup(new CreateGroupViewModel(arrFullStudentsGroup, course.Id),
taskId);

await _solutionsClient.PostSolution(taskId, solutionModel);
var result = await _solutionsClient.PostSolution(taskId, solutionModel);

return Ok(solutionModel);
return Ok(result);
}
}

[HttpPost("automated/{courseId}")]
Expand Down
Loading