Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Sep 10, 2024

Version in pre-commit config differed from the version in the workflow, which could lead to conflicts between the workflow and pre-commit.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian marked this pull request as ready for review September 10, 2024 04:48
Copy link

github-actions bot commented Sep 10, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_9 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024

Coverage Status

coverage: 87.893%. remained the same
when pulling 297fd54 on update-black-python-code-style-workflow
into f483deb on master.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ndgrigorian

I wonder if instead of adding to CHANGELOG directly, we should automate keeping track of changes.

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_10 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The section "Maintenance" is overdue :)

@ndgrigorian ndgrigorian merged commit cd7d41c into master Sep 10, 2024
49 of 53 checks passed
@ndgrigorian ndgrigorian deleted the update-black-python-code-style-workflow branch September 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants