Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jan 14, 2025

This PR fixes a small nonconformity with the array API by making stream a keyword-only argument

Closes #1965

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jan 14, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_442 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_453 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_441 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025

Coverage Status

coverage: 87.681%. remained the same
when pulling 19145cf on fix-to-device-kwargs
into 598082f on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review January 15, 2025 01:27
@ndgrigorian ndgrigorian merged commit 0ac353f into master Jan 15, 2025
60 of 61 checks passed
@ndgrigorian ndgrigorian deleted the fix-to-device-kwargs branch January 15, 2025 01:38
@antonwolfy
Copy link
Collaborator

It seems test coverage for stream keyword is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stream has to be keyword-only argument in to_device method

4 participants