Fix possible itemsize overflows in usm_ndarray from-pointer constructors
#2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
When a bad typenum is passed to functions which make usm_ndarrays from pointers, there was a possible underflow, as itemsize was declared size_t Instead declare itemsize as int and cast to size_t when needed (as itemsize should always fit in int)
ndgrigorian
force-pushed
the
fix-possible-overflow-itemsize
branch
from
2a683e9 to
292bc2a
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_527 ran successfully. |
Collaborator
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_527 ran successfully. |
antonwolfy
reviewed
Feb 20, 2025
antonwolfy
reviewed
Feb 20, 2025
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_530 ran successfully. |
antonwolfy
approved these changes
Feb 21, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian
ndgrigorian
added a commit
that referenced
this pull request
Feb 21, 2025
ndgrigorian
added a commit
that referenced
this pull request
Feb 21, 2025
ndgrigorian
added a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C-API functions which make a
usm_ndarrayfrom a pointer (UsmNDArray_MakeSimpleFromPtrandUsmNDArray_MakeFromPtr) take an integraltypenumargumentIf this argument is invalid, the
itemsizedeclared in the functions would be returned fromtype_bytesizeas -1 and could potentially overflow