-
Notifications
You must be signed in to change notification settings - Fork 31
Fix incorrect results from cumulative_sum and cumulative_prod with dtype=bool
#2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bool->bool and int8->int8 overloads were missing in cumulative_sum and cumulative_prod
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_550 ran successfully. |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_4 ran successfully. |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_9 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, thank you @ndgrigorian
Documents the ticket reported for the JIT failure on CPU
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_10 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @ndgrigorian
This PR resolves gh-2017 by introducing missing dedicated kernels for
bool->boolin the type matrix ofcumulative_sumandcumulative_prod.Also slips in the addition of
int8->int8