Skip to content

Conversation

antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented Apr 23, 2025

Currently a push on master branch in the forked repo starts the Conda package workflow with enabled uploading of the resulting dpctl conda package to public channel (which is not supported and has to be prohibited). Here is a log for reference with the failed step.
This PR proposes to explicitly disable upload job for any repo except origin IntelPython/dpctl.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Apr 23, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 86.41%. remained the same
when pulling 1719a00 on skip-upload-job-in-forked-repo
into 3e74087 on master.

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_151 ran successfully.
Passed: 1108
Failed: 4
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonwolfy antonwolfy merged commit 6ac3a8f into master Apr 23, 2025
73 of 74 checks passed
@ndgrigorian ndgrigorian deleted the skip-upload-job-in-forked-repo branch April 23, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants