Skip to content

Resolve gh-1046 #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

Resolve gh-1046 #2097

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ba1b21
handle unsupported dtype for given device in asarray
ndgrigorian Jun 5, 2025
9544e89
add test for resolution of gh-1046
ndgrigorian Jun 5, 2025
676e418
loop over dpctl.get_devices instead of using device aspects in asarra…
ndgrigorian Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dpctl/tensor/_ctors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ def _asarray_from_usm_ndarray(
raise TypeError(
f"Expected dpctl.tensor.usm_ndarray, got {type(usm_ndary)}"
)
if dtype is None:
dtype = usm_ndary.dtype
if usm_type is None:
usm_type = usm_ndary.usm_type
if sycl_queue is not None:
Expand All @@ -122,6 +120,8 @@ def _asarray_from_usm_ndarray(
copy_q = normalize_queue_device(sycl_queue=sycl_queue, device=exec_q)
else:
copy_q = usm_ndary.sycl_queue
if dtype is None:
dtype = _map_to_device_dtype(usm_ndary.dtype, copy_q)
# Conditions for zero copy:
can_zero_copy = copy is not True
# dtype is unchanged
Expand Down
30 changes: 30 additions & 0 deletions dpctl/tests/test_tensor_asarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,3 +623,33 @@ def test_asarray_support_for_usm_ndarray_protocol(usm_type):
assert x.dtype == y3.dtype
assert y3.usm_data.reference_obj is None
assert dpt.all(x[dpt.newaxis, :] == y3)


@pytest.mark.parametrize("dt", [dpt.float16, dpt.float64, dpt.complex128])
def test_asarray_to_device_with_unsupported_dtype(dt):
aspect = "fp16" if dt == dpt.float16 else "fp64"
try:
d0 = dpctl.select_device_with_aspects(aspect)
except dpctl.SyclDeviceCreationError:
pytest.skip("No device with aspect for test")
d1 = None
try:
d1 = dpctl.select_device_with_aspects("cpu", excluded_aspects=[aspect])
except dpctl.SyclDeviceCreationError:
pass
try:
d1 = dpctl.select_device_with_aspects("gpu", excluded_aspects=[aspect])
except dpctl.SyclDeviceCreationError:
pass
try:
d1 = dpctl.select_device_with_aspects(
"accelerator", excluded_aspects=[aspect]
)
except dpctl.SyclDeviceCreationError:
pass
if d1 is None:
pytest.skip("No device with missing aspect for test")

x = dpt.ones(10, dtype=dt, device=d0)
y = dpt.asarray(x, device=d1)
assert y.sycl_device == d1
Loading