Skip to content

Permit Cython 3.1.0 for Python 3.13 #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2025
Merged

Permit Cython 3.1.0 for Python 3.13 #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c0a3a0
unpin Cython for Python 3.13
ndgrigorian Jul 1, 2025
c8f0c85
conditionally avoid pytest-cov if Python is 3.13
ndgrigorian Jul 3, 2025
6a4eea7
add comments specifying why coverage is not used on Python 3.13
ndgrigorian Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions conda-recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,6 @@ requirements:
- {{ dep }}
{% elif dep.startswith('build>=') %}
- {{ 'python-' ~ dep }}
{% elif dep.startswith('cython') %}
{% if dep.split(';')[1] == "python_version<'3.13'" %}
- {{ dep.split(';')[0] }} # [py<313]
{% else %}
- {{ dep.split(';')[0] }} # [py>=313]
{% endif %}
{% else %}
- {{ dep|replace('_','-') }}
{% endif %}
Expand Down
9 changes: 8 additions & 1 deletion conda-recipe/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,11 @@ set -e

${PYTHON} -c "import dpctl; print(dpctl.__version__)"
${PYTHON} -m dpctl -f
${PYTHON} -m pytest -q -ra --disable-warnings --cov dpctl --cov-report term-missing --pyargs dpctl -vv
# don't use coverage for Python 3.13 due to crashes related to
# Cython >= 3.1.0 and Python >= 3.13
# TODO: remove if crash is triaged
if ${PYTHON} --version 2>&1 | grep -q '^Python 3\.13'; then
${PYTHON} -m pytest -q -ra --disable-warnings --pyargs dpctl -vv
else
${PYTHON} -m pytest -q -ra --disable-warnings --cov dpctl --cov-report term-missing --pyargs dpctl -vv
fi
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ requires = [
"scikit-build>=0.17.0",
"ninja>=1.11.1; platform_system!='Windows'",
"cmake>=3.29.0",
"cython>=3.0.10;python_version<'3.13'",
"cython>=3.0.10,<3.1.0;python_version>='3.13'",
"cython>=3.0.10",
"numpy >=1.23",
# WARNING: check with doc how to upgrade
"versioneer[toml]==0.29"
Expand Down
Loading