Skip to content

Set a link to DLDeviceType enum from __dlpack_device__ docstring #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Set a link to DLDeviceType enum from __dlpack_device__ docstring #2127

merged 1 commit into from
Jul 23, 2025

Conversation

antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented Jul 23, 2025 •
edited
Loading

This PR replaces DLDeviceType as inline literal text with a link to the page with the enum's description.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 23, 2025
@antonwolfy antonwolfy changed the title Set a link to DLDeviceType enum from __dlpack_device__() docstring Set a link to DLDeviceType enum from __dlpack_device__ docstring Jul 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_77 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@ndgrigorian ndgrigorian merged commit 0dbd495 into master Jul 23, 2025
34 checks passed
@ndgrigorian ndgrigorian deleted the add-link-to-DLDeviceType branch July 23, 2025 20:30
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.877% (-0.005%) from 85.882%
when pulling 69203c2 on add-link-to-DLDeviceType
into aa05645 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @ndgrigorian