Skip to content

Remove remaining anonymous namespaces from headers #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

ndgrigorian
Copy link
Collaborator

This PR proposes removing two anonymous namespaces from headers

This will reduce possible binary size bloating, and prevents potential undefined behavior

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

fixes last remaining instances of this antipattern
Copy link

github-actions bot commented Aug 13, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.897% (-0.01%) from 85.908%
when pulling 30b35ba on remove-anonymous-namespaces-from-headers
into c76f67e on master.

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_101 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@ndgrigorian ndgrigorian merged commit b896e5d into master Aug 14, 2025
87 of 111 checks passed
@ndgrigorian ndgrigorian deleted the remove-anonymous-namespaces-from-headers branch August 14, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants