Skip to content

Conversation

sycloid
Copy link
Contributor

@sycloid sycloid commented Sep 12, 2025

Update version of pybind11 dependency used by dpctl to 3.0.1

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@intel-python-devops
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.275% (-0.6%) from 85.908%
when pulling c77bdfa on sycloid:update-pybind11
into 52ab452 on IntelPython:master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @sycloid

I had mistakenly been under the impression 3.9 support had been dropped by pybind11, but it turned out to be only pypy 3.9, so this is a welcome surprise and change

@ndgrigorian
Copy link
Collaborator

also noting that the OS compiler failure is unrelated to this change, most likely related to a recent nightly build, and will be triaged separately

@ndgrigorian ndgrigorian merged commit fc7ef43 into IntelPython:master Sep 15, 2025
62 of 75 checks passed
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution @sycloid

this LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants