Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

previously part of defunct PR #2157

the message

Using compatibility mode for Python, set PYBIND11_FINDPYTHON to NEW/OLD to silence this message

is silenced when find_package(Python REQUIRED COMPONENTS Development.Module) is added to CMake before fetching pybind11, as Python_FOUND will be set

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

add find_package(Python) to find development.module before fetching pybind11
@ndgrigorian
Copy link
Collaborator Author

@sycloid
pinging you as well since this was previously part of your PR, thank you for the addition :)

Copy link

github-actions bot commented Sep 30, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.21.0rc0=py310h93fe807_6 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.262%. remained the same
when pulling 0e46b4b on resolve-cmake-warning-module-development
into d16d31b on master.

@ndgrigorian
Copy link
Collaborator Author

@antonwolfy @vlad-perevezentsev
ping

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is gone now. LGTM

@ndgrigorian ndgrigorian merged commit bf68438 into master Oct 7, 2025
62 of 75 checks passed
@ndgrigorian ndgrigorian deleted the resolve-cmake-warning-module-development branch October 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants