Skip to content

Conversation

jharlow-intel
Copy link
Contributor

@jharlow-intel jharlow-intel commented Oct 3, 2025

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

This is a 2 year old patch that no longer needs to be here, we're well onto 4.x cmake versions that work fine

Copy link

github-actions bot commented Oct 3, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Oct 3, 2025

Array API standard conformance tests for dpctl=0.21.0rc0=py310h93fe807_11 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.264%. remained the same
when pulling 3a18c02 on chore/delete-cmake-patch
into 55546cf on master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndgrigorian ndgrigorian merged commit 63ee44a into master Oct 6, 2025
89 of 99 checks passed
@ndgrigorian ndgrigorian deleted the chore/delete-cmake-patch branch October 6, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants