Account for offset when usm_ndarray constructor is provided buffer that is a usm_ndarray
#2226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes accounting for the offset when
usm_ndarrayconstructor is givenbuffer=xwherexis ausm_ndarray.This means that when a
xis a view, and in particular a view on memory which does not start at the same place as its base array, the memory will start from the same displaced position as the view. For example,where previously,
bwould not have changed at all and the 0 would have appeared ata[1].This has also necessitated disallowing views which are not contiguous as arguments to the
usm_ndarrayconstructor, which aligns with NumPy.