Skip to content

Commit f657178

Browse files
committed
Revert changes pushed without PR
1 parent 15480a8 commit f657178

File tree

5 files changed

+42
-17
lines changed

5 files changed

+42
-17
lines changed

.github/workflows/conda-package.yml

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ env:
1616
CHANNELS: '-c dppy/label/dev -c https://software.repos.intel.com/python/conda/ -c conda-forge --override-channels'
1717
CONDA_BUILD_VERSION: '24.5.1'
1818
CONDA_INDEX_VERSION: '0.5.0'
19-
RERUN_TESTS_ON_FAILURE: 'false'
2019
RUN_TESTS_MAX_ATTEMPTS: 2
2120
TEST_ENV_NAME: 'test'
2221
TEST_SCOPE: >-
@@ -256,14 +255,14 @@ jobs:
256255
python -c "import dpnp, dpctl; dpctl.lsplatform()"
257256
python -c "import dpnp; print(dpnp.__version__)"
258257
259-
- name: Run tests
260-
if: env.RERUN_TESTS_ON_FAILURE != 'true'
261-
run: |
262-
python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
263-
working-directory: ${{ env.tests-path }}
258+
# TODO: run the whole scope once the issues on CPU are resolved
259+
# - name: Run tests
260+
# run: |
261+
# python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
262+
# working-directory: ${{ env.tests-path }}
264263

264+
# TODO: remove once 2024.2 release is published
265265
- name: Run tests
266-
if: env.RERUN_TESTS_ON_FAILURE == 'true'
267266
id: run_tests_linux
268267
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
269268
with:
@@ -412,14 +411,14 @@ jobs:
412411
python -c "import dpnp, dpctl; dpctl.lsplatform()"
413412
python -c "import dpnp; print(dpnp.__version__)"
414413
415-
- name: Run tests
416-
if: env.RERUN_TESTS_ON_FAILURE != 'true'
417-
run: |
418-
python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
419-
working-directory: ${{ env.tests-path }}
414+
# TODO: run the whole scope once the issues on CPU are resolved
415+
# - name: Run tests
416+
# run: |
417+
# python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
418+
# working-directory: ${{ env.tests-path }}
420419

420+
# TODO: remove once 2024.2 release is published
421421
- name: Run tests
422-
if: env.RERUN_TESTS_ON_FAILURE == 'true'
423422
id: run_tests_win
424423
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
425424
with:

conda-recipe/meta.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
{% set required_compiler_and_mkl_version = "2024.2" %}
2-
{% set required_dpctl_version = "0.18.0" %}
1+
{% set required_compiler_and_mkl_version = "2024.0" %}
2+
{% set excluded_compiler_version1 = "2024.0.1" %}
3+
{% set excluded_compiler_version2 = "2024.0.2" %}
4+
{% set excluded_compiler_version3 = "2024.0.3" %}
5+
{% set required_dpctl_version = "0.17.0" %}
36

47
package:
58
name: dpnp
@@ -24,7 +27,8 @@ requirements:
2427
- scikit-build
2528
build:
2629
- {{ compiler('cxx') }}
27-
- {{ compiler('dpcpp') }} >={{ required_compiler_and_mkl_version }}
30+
- {{ compiler('dpcpp') }} >={{ required_compiler_and_mkl_version }},!={{ excluded_compiler_version1 }},!={{ excluded_compiler_version2 }},!={{ excluded_compiler_version3 }} # [win]
31+
- {{ compiler('dpcpp') }} >={{ required_compiler_and_mkl_version }},!={{ excluded_compiler_version1 }},!={{ excluded_compiler_version2 }} # [linux]
2832
- sysroot_linux-64 >=2.28 # [linux]
2933
run:
3034
- python

tests/test_linalg.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1485,6 +1485,10 @@ def test_norm_error(self):
14851485

14861486

14871487
class TestQr:
1488+
# TODO: New packages that fix issue CMPLRLLVM-53771 are only available in internal CI.
1489+
# Skip the tests on cpu until these packages are available for the external CI.
1490+
# Specifically dpcpp_linux-64>=2024.1.0
1491+
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
14881492
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
14891493
@pytest.mark.parametrize(
14901494
"shape",
@@ -1570,6 +1574,7 @@ def test_qr_empty(self, dtype, shape, mode):
15701574

15711575
assert_dtype_allclose(dpnp_r, np_r)
15721576

1577+
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
15731578
@pytest.mark.parametrize(
15741579
"mode",
15751580
["r", "raw", "complete", "reduced"],

tests/test_sycl_queue.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1786,7 +1786,10 @@ def test_array_creation_from_dpctl(copy, device):
17861786
valid_devices,
17871787
ids=[device.filter_string for device in valid_devices],
17881788
)
1789-
@pytest.mark.parametrize("arr_dtype", get_all_dtypes(no_float16=True))
1789+
# TODO need to delete no_bool=True when use dlpack > 0.7 version
1790+
@pytest.mark.parametrize(
1791+
"arr_dtype", get_all_dtypes(no_float16=True, no_bool=True)
1792+
)
17901793
@pytest.mark.parametrize("shape", [tuple(), (2,), (3, 0, 1), (2, 2, 2)])
17911794
def test_from_dlpack(arr_dtype, shape, device):
17921795
X = dpnp.empty(shape=shape, dtype=arr_dtype, device=device)

tests/third_party/cupy/linalg_tests/test_decomposition.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,14 @@ def test_decomposition(self, dtype):
156156
)
157157
@testing.fix_random()
158158
class TestSVD(unittest.TestCase):
159+
# TODO: New packages that fix issue CMPLRLLVM-53771 are only available in internal CI.
160+
# Skip the tests on cpu until these packages are available for the external CI.
161+
# Specifically dpcpp_linux-64>=2024.1.0
162+
@classmethod
163+
def setUpClass(cls):
164+
if is_cpu_device():
165+
raise unittest.SkipTest("CMPLRLLVM-53771")
166+
159167
def setUp(self):
160168
self.seed = testing.generate_seed()
161169

@@ -402,20 +410,26 @@ def _check_result(self, result_cpu, result_gpu):
402410
assert result_cpu.dtype == result_gpu.dtype
403411
testing.assert_allclose(result_cpu, result_gpu, atol=1e-4)
404412

413+
# TODO: New packages that fix issue CMPLRLLVM-53771 are only available in internal CI.
414+
# Skip the tests on cpu until these packages are available for the external CI.
415+
# Specifically dpcpp_linux-64>=2024.1.0
416+
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
405417
@testing.fix_random()
406418
@_condition.repeat(3, 10)
407419
def test_mode(self):
408420
self.check_mode(numpy.random.randn(2, 4), mode=self.mode)
409421
self.check_mode(numpy.random.randn(3, 3), mode=self.mode)
410422
self.check_mode(numpy.random.randn(5, 4), mode=self.mode)
411423

424+
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
412425
@testing.with_requires("numpy>=1.22")
413426
@testing.fix_random()
414427
def test_mode_rank3(self):
415428
self.check_mode(numpy.random.randn(3, 2, 4), mode=self.mode)
416429
self.check_mode(numpy.random.randn(4, 3, 3), mode=self.mode)
417430
self.check_mode(numpy.random.randn(2, 5, 4), mode=self.mode)
418431

432+
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
419433
@testing.with_requires("numpy>=1.22")
420434
@testing.fix_random()
421435
def test_mode_rank4(self):

0 commit comments

Comments
 (0)