Add a COMPILER_VERSION_2025_OR_LATER to be able to run dpnp with both 2024.2 and 2025.0 versions of the compiler/MKL
#2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
npolina4
reviewed
Sep 10, 2024
vtavana
force-pushed
the
remove_deprecated
branch
from
d7a02e5 to
733658c
Compare
vtavana
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
vtavana
changed the title
COMPILER_VERSION_FLAG to avoid deprecated warning in FFT moduleCOMPILER_VERSION_2025_OR_LATER to be able to run dpnp with both 2024.2 and 2025.0 versions of the compiler/MKL
npolina4
reviewed
Sep 11, 2024
npolina4
approved these changes
Sep 11, 2024
Co-authored-by: Natalia Polina <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Sep 11, 2024
…both 2024.2 and 2025.0 versions of the compiler/MKL (#2025) * conditional compiler version * address comments * Update dpnp/backend/extensions/fft/common.hpp Co-authored-by: Natalia Polina <[email protected]> --------- Co-authored-by: Natalia Polina <[email protected]> a7b8960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneMKL FFT 2025.0.0 includes some backward incompatible changes. However, code can not be updated with these changes yet since public CI is still using older version of OneMKL. To keep
dpnpworking with both new compiler/MKL pakcge and the old one, a compile flag is defined to compile the proper part of the code based on the compiler version.