Skip to content

Remove TODO from the code as no plan to support negative values in shape setter #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Remove TODO from the code as no plan to support negative values in shape setter #2032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecaedf2
Remove TODO from the code as no plan to support negative values in sh…
antonwolfy Sep 13, 2024
9045bb2
Merge branch 'master' into remove-todo-for-shape-setter-with-negative…
antonwolfy Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dpnp/dpnp_iface_mathematical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,7 @@ def _gradient_num_diff_2nd_order_interior(
# fix the shape for broadcasting
shape = [1] * ndim
shape[axis] = -1
# TODO: use shape.setter once dpctl#1699 is resolved
# a.shape = b.shape = c.shape = shape

a = a.reshape(shape)
b = b.reshape(shape)
c = c.reshape(shape)
Expand Down
3 changes: 2 additions & 1 deletion tests/third_party/cupy/core_tests/test_ndarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ def test_shape_set(self, xp):
return xp.array(arr.shape)

@pytest.mark.skip(
"dpctl-1699: shape setter does not work with negative shape"
"dpctl-1699: shape setter does not work with negative shape "
"(no plan to support that)"
)
@testing.numpy_cupy_array_equal()
def test_shape_set_infer(self, xp):
Expand Down
Loading