Skip to content

Update dpnp.clip() with Numpy 2.0 #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 26, 2024
Merged

Update dpnp.clip() with Numpy 2.0 #2048

merged 7 commits into from
Sep 26, 2024

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggests using a_min and a_max arguments of dpnp.clip() as None by default to align with Numpy 2.0 instead of using np.NoValue as in Numpy=2.0 and also updates cupy tests for this function

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Sep 24, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev
Please update changelog also.

@vlad-perevezentsev vlad-perevezentsev merged commit 5a368d9 into master Sep 26, 2024
44 of 46 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the update_clip branch September 26, 2024 10:30
github-actions bot added a commit that referenced this pull request Sep 26, 2024
@github-actions
Update dpnp.clip() with Numpy 2.0 (#2048)
2d52ac1 
* Update dpnp.clip to align with numpy 2.0

* Update cupy tests

* Compliance of dpnp.clip() with Array API

* Update CHANGELOG.md 5a368d9
vlad-perevezentsev added a commit that referenced this pull request Sep 27, 2024
@vlad-perevezentsev
Update dpnp.clip() with Numpy 2.0 (#2048)
bd6546e 
* Update dpnp.clip to align with numpy 2.0

* Update cupy tests

* Compliance of dpnp.clip() with Array API

* Update CHANGELOG.md
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Sep 27, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 27, 2024
@github-actions
backport-gh-2048-2074 3e53a02
7fc87d6
vlad-perevezentsev added a commit that referenced this pull request Sep 27, 2024
@vlad-perevezentsev
Update dpnp.clip() with Numpy 2.0 (#2048)
1861f27 
* Update dpnp.clip to align with numpy 2.0

* Update cupy tests

* Compliance of dpnp.clip() with Array API

* Update CHANGELOG.md
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Sep 27, 2024
Closed
6 tasks
antonwolfy pushed a commit that referenced this pull request Sep 27, 2024
@vlad-perevezentsev
Backport gh-2048 & gh-2074 (#2076)
d72d63a 
* Update `dpnp.clip()` with Numpy 2.0 (#2048)

* Update dpnp.clip to align with numpy 2.0

* Update cupy tests

* Compliance of dpnp.clip() with Array API

* Update CHANGELOG.md

* Update cupy tests for dpnp.linalg.solve() (#2074)

* Update cupy tests for dpnp.linalg.solve()

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev @antonwolfy