Skip to content

Workaround issue with lcm kernel on Windows #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Workaround issue with lcm kernel on Windows #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
785adf0
W/a issue with lcm kernel on Windows
antonwolfy Oct 10, 2024
3ccf31d
Merge branch 'master' into fix-lcm-test-on-iris-xe-win
antonwolfy Oct 11, 2024
d62e6f2
Merge branch 'master' into fix-lcm-test-on-iris-xe-win
antonwolfy Oct 11, 2024
ad5a699
Update TODO comment to point on Jira ticket with issue
antonwolfy Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions dpnp/backend/extensions/ufunc/elementwise_functions/gcd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,6 @@ struct OutputType
T2,
std::int64_t,
std::int64_t>,
td_ns::BinaryTypeMapResultEntry<T1,
std::uint64_t,
T2,
std::int64_t,
std::uint64_t>,
td_ns::BinaryTypeMapResultEntry<T1,
std::int64_t,
T2,
std::uint64_t,
std::int64_t>,
td_ns::DefaultResultEntry<void>>::result_type;
};

Expand Down
10 changes: 0 additions & 10 deletions dpnp/backend/extensions/ufunc/elementwise_functions/lcm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,6 @@ struct OutputType
T2,
std::int64_t,
std::int64_t>,
td_ns::BinaryTypeMapResultEntry<T1,
std::uint64_t,
T2,
std::int64_t,
std::uint64_t>,
td_ns::BinaryTypeMapResultEntry<T1,
std::int64_t,
T2,
std::uint64_t,
std::int64_t>,
td_ns::DefaultResultEntry<void>>::result_type;
};

Expand Down
3 changes: 3 additions & 0 deletions dpnp/backend/kernels/elementwise_functions/gcd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ struct GcdFunctor

resT operator()(const argT1 &in1, const argT2 &in2) const
{
static_assert(std::is_same_v<argT1, argT2>,
"Input types are expected to be the same");

return oneapi::dpl::gcd(in1, in2);
}
};
Expand Down
17 changes: 16 additions & 1 deletion dpnp/backend/kernels/elementwise_functions/lcm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,22 @@ struct LcmFunctor

resT operator()(const argT1 &in1, const argT2 &in2) const
{
return oneapi::dpl::lcm(in1, in2);
static_assert(std::is_same_v<argT1, argT2>,
"Input types are expected to be the same");

if (in1 == 0 || in2 == 0)
return 0;

resT res = in1 / oneapi::dpl::gcd(in1, in2) * in2;
if constexpr (std::is_signed_v<argT1>) {
if (res < 0) {
return -res;
}
}
return res;

// TODO: undo the w/a once ONEDPL-1320 is resolved
// return oneapi::dpl::lcm(in1, in2);
}
};
} // namespace dpnp::kernels::lcm
Loading