Skip to content

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 31, 2024

Currently itemset and newbyteorder methods are not implemented for dpnp.ndarray, but TODO comment was left in the code where it was expected to have the implementation.
Since NumPy 2.0 removed these methods from numpy.ndarray it looks as not needed to implement them in dpnp.

So the PR proposes to clean up the code and to remove comments per itemset and newbyteorder methods, since they are not going to be implemented for dpnp.ndarray anymore.
The link of the methods are also removed from generated dpnp documentation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Oct 31, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit b9dfc72 into master Oct 31, 2024
46 checks passed
@antonwolfy antonwolfy deleted the remove-itemset-newbyteorder-methods branch October 31, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants