Skip to content

Fix DeprecationWarning: pkg_resources #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2024
Merged

Fix DeprecationWarning: pkg_resources #2156

merged 3 commits into from
Nov 7, 2024

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggests using from packaging.requirements import Requirement instead of import pkg_resources to avoid DeprecationWarning.
These changes also remove ignoring of DeprecationWarning in filterwarnings pytest settings

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Nov 7, 2024
antonwolfy
antonwolfy approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good test improvement, many thanks @vlad-perevezentsev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vlad-perevezentsev vlad-perevezentsev merged commit 06f6e33 into master Nov 7, 2024
46 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the remove_pkg_resources branch November 7, 2024 15:13
github-actions bot added a commit that referenced this pull request Nov 7, 2024
@github-actions
Fix DeprecationWarning: pkg_resources (#2156)
9cdba6e 
* Replace pkg_resources to packaging to avoid DeprecationWarning

* A small update cupy with_requires() func

* Remove pkg_resources filterwarning 06f6e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev @antonwolfy