Skip to content

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 12, 2024

Looking into the overall time of the Conda package action, it looks actions/cache step doesn't provide significant speed up, but complicates the flow.
Thus the PR proposes to remove the steps.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy changed the title Enable pkgs-dirs option of conda-incubator/setup-miniconda Remove actions/cache steps Nov 12, 2024
@antonwolfy antonwolfy marked this pull request as ready for review November 12, 2024 17:36
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 923eb84 into master Nov 13, 2024
45 of 46 checks passed
@antonwolfy antonwolfy deleted the setup-miniconda-configurable-cache branch November 13, 2024 13:31
github-actions bot added a commit that referenced this pull request Nov 13, 2024
* Make conda's package directory configurable to speed up GitHub hosted Windows runners

* Use double backslash on Windows

* Use bash shell

* Update test steps

* Enable use-only-tar-bz2 as stated in documentation of conda-incubator

* use-only-tar-bz2 option does not work with mamba

* Remove use of actions/cache step 923eb84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants