Skip to content

Conversation

ekomarova
Copy link
Contributor

@ekomarova ekomarova commented Nov 12, 2024

This PR adds the implementation of dpnp.common_type

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ekomarova
Copy link
Contributor Author

The following 2 tests fail when check_supported_arrays_type of common_type is called

tests.third_party.cupy.test_type_routines.TestCommonType.test_common_type_single_argument
     TypeError: An array must be any of supported type, but got <class 'int'>

tests.third_party.cupy.test_type_routines.TestCommonType.test_common_type_two_arguments
     TypeError: An array must be any of supported type, but got <class 'int'>

Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2167/index.html

@ekomarova ekomarova self-assigned this Dec 16, 2024
@antonwolfy
Copy link
Contributor

The implementation of dpnp.common_type() was completed in scope of #2391

@antonwolfy antonwolfy closed this Mar 27, 2025
@antonwolfy antonwolfy deleted the impl/common_type branch May 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants