Skip to content

Conversation

AlexanderKalistratov
Copy link
Collaborator

  • Implementation of dot product sliding window which is can be used to implement both correlate and convolve functions.
  • Implementation of correlate function using dot product sliding window

@AlexanderKalistratov AlexanderKalistratov changed the title Initial implementation of correlate Implementation of correlate Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@AlexanderKalistratov AlexanderKalistratov force-pushed the correlate branch 3 times, most recently from be09e32 to 91fd41f Compare December 7, 2024 16:57
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexanderKalistratov , LGTM

@antonwolfy antonwolfy removed the request for review from npolina4 December 9, 2024 20:52
@AlexanderKalistratov AlexanderKalistratov merged commit be6e00f into master Dec 9, 2024
44 of 47 checks passed
@AlexanderKalistratov AlexanderKalistratov deleted the correlate branch December 9, 2024 20:56
github-actions bot added a commit that referenced this pull request Dec 9, 2024
* Implementation of dot product sliding window which is can be used to
implement both `correlate` and `convolve` functions.
* Implementation of `correlate` function using dot product sliding
window be6e00f
AlexanderKalistratov added a commit that referenced this pull request Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy
correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html)
* If `method == 'auto'` method is choosing automatically between
`direct` and `fft`
* Added implementation of fft-based correlation
* fft-based implementation may have accuracy issues, so it is validated
in non-standard way.

Depends on: #2180,
#2202

---------

Co-authored-by: Anton <[email protected]>
github-actions bot added a commit that referenced this pull request Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy
correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html)
* If `method == 'auto'` method is choosing automatically between
`direct` and `fft`
* Added implementation of fft-based correlation
* fft-based implementation may have accuracy issues, so it is validated
in non-standard way.

Depends on: #2180,
#2202

---------

Co-authored-by: Anton <[email protected]> da2eeba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants