Skip to content

Configure default shell per OS in Upload step #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

Configure default shell per OS in Upload step #2182

merged 2 commits into from
Nov 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 18, 2024 •
edited
Loading

The PR rolls back a part of changes done in #2179, because the Upload step started to be failed on Linux.
Instead it proposes to configure default shell per OS in Upload step.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 18, 2024
@antonwolfy antonwolfy force-pushed the resolve-issue-with-linux-upload-in-public-ci branch 2 times, most recently from 717fa05 to 04ed214 Compare November 18, 2024 21:20
@antonwolfy antonwolfy force-pushed the resolve-issue-with-linux-upload-in-public-ci branch from 04ed214 to 77f8133 Compare November 18, 2024 21:28
@antonwolfy antonwolfy changed the title Pass -l option to bash where anaconda command runs Configure default shell per OS in Upload step. Nov 18, 2024
@antonwolfy antonwolfy marked this pull request as ready for review November 18, 2024 21:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy changed the title Configure default shell per OS in Upload step. Configure default shell per OS in Upload step Nov 18, 2024
@antonwolfy antonwolfy merged commit c6c478a into master Nov 19, 2024
46 checks passed
@antonwolfy antonwolfy deleted the resolve-issue-with-linux-upload-in-public-ci branch November 19, 2024 08:13
github-actions bot added a commit that referenced this pull request Nov 19, 2024
@github-actions
Configure default shell per OS (#2182) c6c478a
71970e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

1 more reviewer

@vtavana vtavana vtavana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @vtavana