Skip to content

simplify dpnp.average implementation #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2024
Merged

simplify dpnp.average implementation #2189

merged 2 commits into from
Nov 21, 2024

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Nov 20, 2024

In this PR, dpnp.average implementation is simplified.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review November 20, 2024 23:56
antonwolfy
antonwolfy reviewed Nov 21, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit b839c40 into master Nov 21, 2024
45 checks passed
@vtavana vtavana deleted the update-average branch November 21, 2024 15:20
github-actions bot added a commit that referenced this pull request Nov 21, 2024
@github-actions
simplify dpnp.average implementation (#2189)
3e5d800 
* simplify dpnp.average implementation

* address comments b839c40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana @antonwolfy