Skip to content

Remove links to isnat function from docs #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2025
Merged

Remove links to isnat function from docs #2250

merged 2 commits into from
Jan 9, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 8, 2025 •
edited
Loading

isnat function is not planning to be supported by dpnp, because it requires an input array with datetime or timedelta data type.
The PR proposes to clean up the documentation and to remove the links to isnat function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 65.08%. remained the same
when pulling 7418c47 on remove-links-to-isnat-from-docs
into 659629d on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 8d7ed21 into master Jan 9, 2025
53 of 54 checks passed
@antonwolfy antonwolfy deleted the remove-links-to-isnat-from-docs branch January 9, 2025 11:30
github-actions bot added a commit that referenced this pull request Jan 9, 2025
@github-actions
Remove links to isnat function from docs (#2250)
f8b1187 
`isnat` function is not planning to be supported by dpnp, because it
requires an input array with datetime or timedelta data type.
The PR proposes to clean up the documentation and to remove the links to
`isnat` function. 8d7ed21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev