Skip to content

Add descending keyword argument to dpnp.sort and dpnp.argsort #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2025
Merged

Add descending keyword argument to dpnp.sort and dpnp.argsort #2269

merged 5 commits into from
Jan 22, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 21, 2025 •
edited
Loading

The PR proposes to add descending keyword argument to sorting functions, including dpnp.sort, dpnp.argsort and dpnp.ndarray.sort, dpnp.ndarray.argsort methods.

The keyword is mandated according to python array API. The corresponding muted tests are enabled in python array API compliance scope.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 21, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2025 •
edited
Loading

Coverage Status

coverage: 70.856%. remained the same
when pulling f200348 on add-descending-argument-to-sort-argsort
into 356184a on master.

@antonwolfy antonwolfy marked this pull request as ready for review January 21, 2025 12:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit d415fe2 into master Jan 22, 2025
46 of 53 checks passed
@antonwolfy antonwolfy deleted the add-descending-argument-to-sort-argsort branch January 22, 2025 08:08
github-actions bot added a commit that referenced this pull request Jan 22, 2025
@github-actions
Add descending keyword argument to dpnp.sort and dpnp.argsort (#…
faaf424 
…2269)

The PR proposes to add `descending` keyword argument to sorting
functions, including `dpnp.sort`, `dpnp.argsort` and
`dpnp.ndarray.sort`, `dpnp.ndarray.argsort` methods.

The keyword is mandated according to python array API. The corresponding
muted tests are enabled in python array API compliance scope. d415fe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

1 more reviewer

@vtavana vtavana vtavana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vtavana