Skip to content

update test_strides.py file #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 17, 2025
Merged

update test_strides.py file #2317

merged 4 commits into from
Feb 17, 2025

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Feb 16, 2025 •
edited
Loading

In this PR, test_strides.py file has been updated to reduce duplication.

In addition, the test for dpnp.sign has been updated to better validate cases involving complex numbers.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_21 ran successfully.
Passed: 992
Failed: 0
Skipped: 22

@vtavana vtavana marked this pull request as ready for review February 16, 2025 04:53
antonwolfy
antonwolfy approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.742%. remained the same
when pulling 2cd63f7 on update-test_strides.py
into 89cb658 on master.

@vtavana vtavana merged commit 1eb1592 into master Feb 17, 2025
68 of 70 checks passed
@vtavana vtavana deleted the update-test_strides.py branch February 17, 2025 20:07
github-actions bot added a commit that referenced this pull request Feb 17, 2025
@github-actions
update test_strides.py file (#2317)
c8d8e5a 
In this PR, `test_strides.py` file has been updated to reduce
duplication.

In addition, the test for `dpnp.sign` has been updated to better
validate cases involving complex numbers. 1eb1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @coveralls @antonwolfy