Skip to content

improve covergae dpnp_iface_manipulation.py #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2025
Merged

improve covergae dpnp_iface_manipulation.py #2326

merged 5 commits into from
Feb 20, 2025

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Feb 18, 2025

After merging #2230, coverage for dpnp.iface_manipulation.py was decreased related to dpnp.copyto function. This PR adds new tests to improve the coverage and updates the logic used in dpnp.copyto to pass the new tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 18, 2025 •
edited
Loading

Coverage Status

coverage: 71.781% (+0.02%) from 71.762%
when pulling cedcfcb on improve-coverage-manipulaiton
into af0fc93 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.17.0dev7=py312he4f9c94_9 ran successfully.
Passed: 1004
Failed: 0
Skipped: 10

@vtavana vtavana force-pushed the improve-coverage-manipulaiton branch from 301858b to d0259b0 Compare February 19, 2025 00:14
@vtavana vtavana marked this pull request as ready for review February 19, 2025 02:41
antonwolfy
antonwolfy reviewed Feb 19, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for the improvement, LGTM!

@vtavana vtavana merged commit e24fa99 into master Feb 20, 2025
63 of 66 checks passed
@vtavana vtavana deleted the improve-coverage-manipulaiton branch February 20, 2025 20:31
github-actions bot added a commit that referenced this pull request Feb 20, 2025
@github-actions
improve covergae dpnp_iface_manipulation.py (#2326)
1155935 
After merging #2230, coverage for `dpnp.iface_manipulation.py` was
decreased related to `dpnp.copyto` function. This PR adds new tests to
improve the coverage and updates the logic used in `dpnp.copyto` to pass
the new tests. e24fa99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @coveralls @antonwolfy