Skip to content

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 19, 2025

The PR proposes to switch conda-build version from 25.1.1 to 25.1.2.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Feb 19, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 19, 2025

Coverage Status

coverage: 71.883%. remained the same
when pulling 18de38d on bump-conda-build-index-version
into d9d0f35 on master.

@antonwolfy antonwolfy marked this pull request as draft February 19, 2025 10:35
@antonwolfy
Copy link
Contributor Author

It seems the compatibility fix of conda-build with the latest py-lief=0.16 doesn't work properly and caused unexpected exception raised:

  File "/home/runner/miniconda3/envs/build/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 1233, in get_linkages_memoized
    return get_linkages(
           ^^^^^^^^^^^^^
  File "/home/runner/miniconda3/envs/build/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 640, in get_linkages
    result_lief = inspect_linkages_lief(
                  ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/miniconda3/envs/build/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 491, in inspect_linkages_lief
    if binary.type == ELF_CLASS.CLASS64:
                      ^^^^^^^^^^^^^^^^^
AttributeError: type object 'CLASS' has no attribute 'CLASS64'

In this PR, test suit is updated to 1) use `generate_random_numpy_array`
for generating inputs of a few functions, 2) avoid unnecessary
conversion to numpy array where possible, 3) to modify the format.

---------

Co-authored-by: Anton <[email protected]>

Update build_conda_pkg.yml
@antonwolfy antonwolfy force-pushed the bump-conda-build-index-version branch from d1c6df7 to e0155fe Compare February 27, 2025 10:11
@antonwolfy
Copy link
Contributor Author

antonwolfy commented Feb 27, 2025

It seems the compatibility fix of conda-build with the latest py-lief=0.16 doesn't work properly and caused unexpected exception raised:

It has been resolved by the latest rebuild in conda-build feedstock, py-lief is again limited to 0.14.1.

@antonwolfy antonwolfy marked this pull request as ready for review February 27, 2025 10:35
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_7 ran successfully.
Passed: 1006
Failed: 0
Skipped: 16

Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 456e55c into master Feb 27, 2025
67 of 68 checks passed
@antonwolfy antonwolfy deleted the bump-conda-build-index-version branch February 27, 2025 12:42
github-actions bot added a commit that referenced this pull request Feb 27, 2025
The PR proposes to switch `conda-build` version from `25.1.1` to
`25.1.2`. 456e55c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants