Skip to content

create a common file to facilitate the implementation of future window functions. #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

create a common file to facilitate the implementation of future window functions. #2357

merged 3 commits into from
Mar 4, 2025
+119 −131

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Mar 4, 2025 •
edited
Loading

In this PR, a common file has been created to facilitate the implementation of future window functions.
In addition a few issues in documentation are addressed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 4, 2025
@vtavana vtavana changed the title create a common to facilitate the implementation of future window functions. create a common file to facilitate the implementation of future window functions. Mar 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2025 •
edited
Loading

Coverage Status

Changes unknown
when pulling dbb30a9 on impl-window-common
into ** on master**.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_21 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@vtavana vtavana marked this pull request as ready for review March 4, 2025 05:15
@antonwolfy antonwolfy added this to the 0.18.0 release milestone Mar 4, 2025
antonwolfy
antonwolfy approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit 2700d92 into master Mar 4, 2025
64 of 68 checks passed
@vtavana vtavana deleted the impl-window-common branch March 4, 2025 13:26
github-actions bot added a commit that referenced this pull request Mar 4, 2025
@github-actions
create a common file to facilitate the implementation of future windo…
079ff3b 
…w functions. (#2357)

In this PR, a common file has been created to facilitate the
implementation of future window functions.
In addition a few issues in documentation are addressed. 2700d92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

0.18.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @coveralls @antonwolfy