Skip to content

update test_nanfunctions.py #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2025
Merged

update test_nanfunctions.py #2362

merged 4 commits into from
Mar 6, 2025

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Mar 5, 2025

In this PR, test_nanfunctions.py is updated. In addition, a few minor changes are made in other tests files.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_27 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@coveralls
Copy link
Collaborator

coveralls commented Mar 5, 2025 •
edited
Loading

Coverage Status

coverage: 71.952%. remained the same
when pulling bda3ffe on update-nan-tests
into 3984679 on master.

@vtavana vtavana force-pushed the update-nan-tests branch from 96c7b50 to 31c6355 Compare March 5, 2025 20:26
@vtavana vtavana marked this pull request as ready for review March 6, 2025 00:15
antonwolfy
antonwolfy reviewed Mar 6, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

@vtavana vtavana merged commit 58bd91e into master Mar 6, 2025
64 of 66 checks passed
@vtavana vtavana deleted the update-nan-tests branch March 6, 2025 17:36
github-actions bot added a commit that referenced this pull request Mar 6, 2025
@github-actions
update test_nanfunctions.py (#2362)
2ca1d33 
In this PR, `test_nanfunctions.py` is updated. In addition, a few minor
changes are made in other tests files. 58bd91e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @coveralls @antonwolfy