Skip to content

get rid of explicit instantiation in fft backend #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

get rid of explicit instantiation in fft backend #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dpnp/backend/extensions/fft/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
set(python_module_name _fft_impl)
set(_module_src
${CMAKE_CURRENT_SOURCE_DIR}/fft_py.cpp
${CMAKE_CURRENT_SOURCE_DIR}/in_place.cpp
${CMAKE_CURRENT_SOURCE_DIR}/out_of_place.cpp
)

pybind11_add_module(${python_module_name} MODULE ${_module_src})
Expand Down
2 changes: 2 additions & 0 deletions dpnp/backend/extensions/fft/in_place.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,5 @@ std::pair<sycl::event, sycl::event>
const std::vector<sycl::event> &depends);

} // namespace dpnp::extensions::fft

#include "in_place.tpp" // Include template definition
19 changes: 1 addition & 18 deletions dpnp/backend/extensions/fft/in_place.cpp → dpnp/backend/extensions/fft/in_place.tpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
// THE POSSIBILITY OF SUCH DAMAGE.
//*****************************************************************************

#pragma once
#include <stdexcept>

#include <oneapi/mkl.hpp>
Expand All @@ -32,7 +33,6 @@

#include "common.hpp"
#include "fft_utils.hpp"
#include "in_place.hpp"
// dpctl tensor headers
#include "utils/output_validation.hpp"

Expand Down Expand Up @@ -107,21 +107,4 @@ std::pair<sycl::event, sycl::event>
return std::make_pair(fft_event, args_ev);
}

// Explicit instantiations
// single precision c2c FFT
template std::pair<sycl::event, sycl::event> compute_fft_in_place(
DescriptorWrapper<mkl_dft::precision::SINGLE, mkl_dft::domain::COMPLEX>
&descr,
const dpctl::tensor::usm_ndarray &in_out,
const bool is_forward,
const std::vector<sycl::event> &depends);

// double precision c2c FFT
template std::pair<sycl::event, sycl::event> compute_fft_in_place(
DescriptorWrapper<mkl_dft::precision::DOUBLE, mkl_dft::domain::COMPLEX>
&descr,
const dpctl::tensor::usm_ndarray &in_out,
const bool is_forward,
const std::vector<sycl::event> &depends);

} // namespace dpnp::extensions::fft
2 changes: 2 additions & 0 deletions dpnp/backend/extensions/fft/out_of_place.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,5 @@ std::pair<sycl::event, sycl::event>
const std::vector<sycl::event> &depends);

} // namespace dpnp::extensions::fft

#include "out_of_place.tpp" // Include template definition
36 changes: 1 addition & 35 deletions dpnp/backend/extensions/fft/out_of_place.cpp → dpnp/backend/extensions/fft/out_of_place.tpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
// THE POSSIBILITY OF SUCH DAMAGE.
//*****************************************************************************

#pragma once
#include <stdexcept>

#include <oneapi/mkl.hpp>
Expand All @@ -32,7 +33,6 @@

#include "common.hpp"
#include "fft_utils.hpp"
#include "out_of_place.hpp"
// dpctl tensor headers
#include "utils/memory_overlap.hpp"
#include "utils/output_validation.hpp"
Expand Down Expand Up @@ -167,38 +167,4 @@ std::pair<sycl::event, sycl::event>
return std::make_pair(fft_event, args_ev);
}

// Explicit instantiations
// single precision c2c FFT
template std::pair<sycl::event, sycl::event> compute_fft_out_of_place(
DescriptorWrapper<mkl_dft::precision::SINGLE, mkl_dft::domain::COMPLEX>
&descr,
const dpctl::tensor::usm_ndarray &in,
const dpctl::tensor::usm_ndarray &out,
const bool is_forward,
const std::vector<sycl::event> &depends);

// double precision c2c FFT
template std::pair<sycl::event, sycl::event> compute_fft_out_of_place(
DescriptorWrapper<mkl_dft::precision::DOUBLE, mkl_dft::domain::COMPLEX>
&descr,
const dpctl::tensor::usm_ndarray &in,
const dpctl::tensor::usm_ndarray &out,
const bool is_forward,
const std::vector<sycl::event> &depends);

// single precision r2c/c2r FFT
template std::pair<sycl::event, sycl::event> compute_fft_out_of_place(
DescriptorWrapper<mkl_dft::precision::SINGLE, mkl_dft::domain::REAL> &descr,
const dpctl::tensor::usm_ndarray &in,
const dpctl::tensor::usm_ndarray &out,
const bool is_forward,
const std::vector<sycl::event> &depends);

// double precision r2c/c2r FFT
template std::pair<sycl::event, sycl::event> compute_fft_out_of_place(
DescriptorWrapper<mkl_dft::precision::DOUBLE, mkl_dft::domain::REAL> &descr,
const dpctl::tensor::usm_ndarray &in,
const dpctl::tensor::usm_ndarray &out,
const bool is_forward,
const std::vector<sycl::event> &depends);
} // namespace dpnp::extensions::fft
Loading