Skip to content

update dpnp.fix to align it with numpy>=2.1 #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 29, 2025
Merged

update dpnp.fix to align it with numpy>=2.1 #2392

merged 11 commits into from
Mar 29, 2025

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Mar 26, 2025 •
edited
Loading

In this PR, dpnp.fix is updated to align with numpy>=2.1. Previously, output dtype was always float but now output has the same dtype of inputs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2025 •
edited
Loading

Coverage Status

coverage: 72.236% (+0.03%) from 72.209%
when pulling 9cb65be on update-dpnp-fix
into 05b820d on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_63 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

@vtavana vtavana force-pushed the update-dpnp-fix branch 2 times, most recently from daf143e to 5f29613 Compare March 27, 2025 00:28
@vtavana vtavana marked this pull request as ready for review March 27, 2025 03:05
antonwolfy
antonwolfy reviewed Mar 27, 2025
View reviewed changes
@vtavana vtavana changed the title update dpnp.fix docstring update dpnp.fix to align it with numpy-2.2.0 Mar 27, 2025
@vtavana vtavana changed the title update dpnp.fix to align it with numpy-2.2.0 update dpnp.fix to align it with numpy>=2.1 Mar 27, 2025
antonwolfy
antonwolfy reviewed Mar 27, 2025
View reviewed changes
Vahid Tavanashad and others added 2 commits March 27, 2025 08:25
antonwolfy
antonwolfy reviewed Mar 27, 2025
View reviewed changes
@vtavana vtavana added this to the 0.18.0 release milestone Mar 28, 2025
antonwolfy
antonwolfy reviewed Mar 28, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

@vtavana vtavana merged commit 5288b62 into master Mar 29, 2025
67 checks passed
@vtavana vtavana deleted the update-dpnp-fix branch March 29, 2025 15:07
github-actions bot added a commit that referenced this pull request Mar 29, 2025
@github-actions
update dpnp.fix to align it with numpy>=2.1 (#2392)
14d3e47 
In this PR, `dpnp.fix` is updated to align with numpy>=2.1. Previously,
output dtype was always float but now output has the same dtype of
inputs. 5288b62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

0.18.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @coveralls @antonwolfy