fix issues when running tests with all integer dtypes on GPU w/o support for fp64 #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_13 ran successfully. |
Collaborator
vtavana
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
approved these changes
Apr 30, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vtavana, LGTM
github-actions bot
added a commit
that referenced
this pull request
Apr 30, 2025
…ort for fp64 (#2430) The following tests fails when running the test suite with all integer dtypes included on a GPU device that does not support fp64. FAILED dpnp/tests/test_linalg.py::TestCond::test_basic FAILED dpnp/tests/test_linalg.py::TestSvd::test_svd FAILED dpnp/tests/test_linalg.py::TestPinv::test_pinv FAILED dpnp/tests/third_party/cupy/creation_tests/test_ranges.py::TestRanges::test_linspace_mixed_start_stop2 FAILED dpnp/tests/third_party/cupy/math_tests/test_explog.py::TestExplog::test_logaddexp2 FAILED dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_discont_and_period FAILED dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_period This PR fixes them all. 6a81e55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests fails when running the test suite with all integer dtypes included on a GPU device that does not support fp64.
FAILED dpnp/tests/test_linalg.py::TestCond::test_basic
FAILED dpnp/tests/test_linalg.py::TestSvd::test_svd
FAILED dpnp/tests/test_linalg.py::TestPinv::test_pinv
FAILED dpnp/tests/third_party/cupy/creation_tests/test_ranges.py::TestRanges::test_linspace_mixed_start_stop2
FAILED dpnp/tests/third_party/cupy/math_tests/test_explog.py::TestExplog::test_logaddexp2
FAILED dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_discont_and_period
FAILED dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py::TestUnwrap::test_unwrap_1dim_with_period
This PR fixes them all.